Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add worldToImage and imageToWorld utilities #85

Merged
merged 4 commits into from
Apr 27, 2022
Merged

feat: Add worldToImage and imageToWorld utilities #85

merged 4 commits into from
Apr 27, 2022

Conversation

sedghi
Copy link
Member

@sedghi sedghi commented Apr 27, 2022 •
edited
Loading

add worldToImage and imageToWorld utilities

@sedghi sedghi requested a review from JamesAPetts April 27, 2022 03:25
@sedghi sedghi changed the title Feat/worl to image feat: Add worldToImage and imageToWorld utilities Apr 27, 2022
JamesAPetts
JamesAPetts requested changes Apr 27, 2022
View reviewed changes
Copy link
Member

@JamesAPetts JamesAPetts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few points we should discuss before continuing here :).

packages/core/src/RenderingEngine/StackViewport.ts Outdated Show resolved Hide resolved
packages/core/src/utilities/imageToWorldCoords.ts Show resolved Hide resolved
packages/core/src/utilities/imageToWorldCoords.ts Show resolved Hide resolved
packages/core/src/utilities/imageToWorldCoords.ts Outdated Show resolved Hide resolved
packages/core/src/utilities/worldToImageCoords.ts Outdated Show resolved Hide resolved
packages/core/src/utilities/worldToImageCoords.ts Outdated Show resolved Hide resolved
packages/core/src/utilities/worldToImageCoords.ts Outdated Show resolved Hide resolved
packages/core/src/utilities/worldToImageCoords.ts Outdated Show resolved Hide resolved
packages/core/src/utilities/worldToImageCoords.ts Outdated Show resolved Hide resolved
packages/core/src/utilities/worldToImageCoords.ts Outdated Show resolved Hide resolved
JamesAPetts
JamesAPetts approved these changes Apr 27, 2022
View reviewed changes
Copy link
Member

@JamesAPetts JamesAPetts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, the imageToWorldCoords is much simpler now.
One minor comment about... comments. But otherwise LGTM.

packages/core/src/RenderingEngine/StackViewport.ts Show resolved Hide resolved
@sedghi sedghi merged commit 54e1b7f into main Apr 27, 2022
@swederik swederik deleted the feat/worlToImage branch July 8, 2022 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesAPetts JamesAPetts JamesAPetts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sedghi @JamesAPetts