From aefdbb0c2c3d04aff642fe4b4bc341ffbae163e4 Mon Sep 17 00:00:00 2001 From: Leonardo Campos Date: Thu, 8 Feb 2024 11:18:04 -0300 Subject: [PATCH] feat(contourSeg) polyline decimate :: code review --- packages/tools/src/tools/annotation/LivewireContourTool.ts | 2 +- packages/tools/src/tools/annotation/PlanarFreehandROITool.ts | 2 +- packages/tools/src/tools/annotation/SplineROITool.ts | 2 +- packages/tools/src/tools/base/ContourBaseTool.ts | 4 ---- 4 files changed, 3 insertions(+), 7 deletions(-) diff --git a/packages/tools/src/tools/annotation/LivewireContourTool.ts b/packages/tools/src/tools/annotation/LivewireContourTool.ts index 2f2aef9d65..a297ed9d9a 100644 --- a/packages/tools/src/tools/annotation/LivewireContourTool.ts +++ b/packages/tools/src/tools/annotation/LivewireContourTool.ts @@ -113,7 +113,7 @@ class LivewireContourTool extends ContourSegmentationBaseTool { * for better performance and storage. */ decimate: { - enabled: true, + enabled: false, /** A maximum given distance 'epsilon' to decide if a point should or * shouldn't be added the resulting polyline which will have a lower * number of points for higher `epsilon` values. diff --git a/packages/tools/src/tools/annotation/PlanarFreehandROITool.ts b/packages/tools/src/tools/annotation/PlanarFreehandROITool.ts index e28f164c03..0dee9ae8aa 100644 --- a/packages/tools/src/tools/annotation/PlanarFreehandROITool.ts +++ b/packages/tools/src/tools/annotation/PlanarFreehandROITool.ts @@ -236,7 +236,7 @@ class PlanarFreehandROITool extends ContourSegmentationBaseTool { * for better performance and storage. */ decimate: { - enabled: true, + enabled: false, /** A maximum given distance 'epsilon' to decide if a point should or * shouldn't be added the resulting polyline which will have a lower * number of points for higher `epsilon` values. diff --git a/packages/tools/src/tools/annotation/SplineROITool.ts b/packages/tools/src/tools/annotation/SplineROITool.ts index 12026dbf2c..6c64d661ca 100644 --- a/packages/tools/src/tools/annotation/SplineROITool.ts +++ b/packages/tools/src/tools/annotation/SplineROITool.ts @@ -125,7 +125,7 @@ class SplineROITool extends ContourSegmentationBaseTool { * for better performance and storage. */ decimate: { - enabled: true, + enabled: false, /** A maximum given distance 'epsilon' to decide if a point should or * shouldn't be added the resulting polyline which will have a lower * number of points for higher `epsilon` values. diff --git a/packages/tools/src/tools/base/ContourBaseTool.ts b/packages/tools/src/tools/base/ContourBaseTool.ts index 21ca2e1a23..3cc78bb01e 100644 --- a/packages/tools/src/tools/base/ContourBaseTool.ts +++ b/packages/tools/src/tools/base/ContourBaseTool.ts @@ -224,10 +224,6 @@ abstract class ContourBaseTool extends AnnotationTool { } ) { const decimateConfig = this.configuration?.decimate || {}; - console.log('>>>>> decimate', { - enabled: !!decimateConfig.enabled, - epsilon: decimateConfig.epsilon, - }); updateContourPolyline(annotation, polylineData, transforms, { decimate: {