Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(splines): add auto removing when outside image for SplineROITool series #1021

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

Blackman99
Copy link
Contributor

Context

Make SplineROITool auto removing when there's at least one of the points is outside of image range.

Changes & Results

In the _endCallback, determine whether to removing the annotation based on the points position is within image range or not.

Testing

cs-spline-remove-when-outside-image

Checklist

PR

  • My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

Public Documentation Updates

  • The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • "OS: Ubuntu 23.10
  • "Node version: 20.10.0
  • "Browser: Chrome 120.0.6099.225

Copy link

netlify bot commented Jan 22, 2024

Deploy Preview for cornerstone-3d-docs ready!

Name Link
🔨 Latest commit bc445dc
🔍 Latest deploy log https://app.netlify.com/sites/cornerstone-3d-docs/deploys/65ae337014ae8800087edd9f
😎 Deploy Preview https://deploy-preview-1021--cornerstone-3d-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sedghi sedghi changed the title feat: add auto removing when outside image for SplineROITool series fix(splines): add auto removing when outside image for SplineROITool series Jan 22, 2024
@sedghi sedghi merged commit 6f24dd3 into cornerstonejs:main Jan 22, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants