Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(WindowLevelTool): attempt to set zero width color range #1037

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

Blackman99
Copy link
Contributor

Context

When using mouse with WindowLevelTool. When the voiRange.upper is equal to or less than voiRange.lower, would cause attempt to set zero width color range in the console.

Changes & Results

Add a condition to ensure voiRange.upper is larger than voiRange.lower

Testing

  • Before
    cs-window-level-before-fix
  • After
    cs-window-level-after-fix

Checklist

PR

  • My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

Public Documentation Updates

  • The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • OS: Ubuntu 23.10
  • Node version: 20.10.0
  • Browser: Chrome 120.0.6099.225

Copy link

netlify bot commented Jan 25, 2024

Deploy Preview for cornerstone-3d-docs ready!

Name Link
🔨 Latest commit 98f9390
🔍 Latest deploy log https://app.netlify.com/sites/cornerstone-3d-docs/deploys/65b225f8c7e39900085b6aae
😎 Deploy Preview https://deploy-preview-1037--cornerstone-3d-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@sedghi sedghi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sedghi sedghi merged commit bcdc704 into cornerstonejs:main Jan 26, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants