feat(contours): add polySeg converters to contour targets #1075
Conversation
…at/enhanced-polyseg
…d contour representation
✅ Deploy Preview for cornerstone-3d-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
sedghi
changed the title
| @@ -0,0 +1,11 @@ | |||
| // Axis-aligned bounding box 2D | |||
| type AABB3 = { | |||
There was a problem hiding this comment.
Can we call this MinMax or something like that? Also, can we re-use one of the existing types? Or, replace the existing ones with this one?
There was a problem hiding this comment.
Would you like to learn about AABB min max? It's actually a well-known concept that is widely recognized.
There was a problem hiding this comment.
It is the same as the bounding box, but different representation
There was a problem hiding this comment.
Yeah I think it makes sense to call it bounding box, maybe we do that after the demo. @lscoder
...nt/segmentation/polySeg/Contour/utils/createAndAddContourSegmentationsFromClippedSurfaces.ts
Outdated
Show resolved
Hide resolved
| // fillAlpha requires further work. | ||
| for (let i = 0; i < lineSegments.length; i++) { | ||
| const line = lineSegments[i]; | ||
| const polyline = []; |
There was a problem hiding this comment.
Can you use the PointsArray class here?
There was a problem hiding this comment.
How can i use it? i need to get my head around it
packages/tools/src/stateManagement/segmentation/helpers/clipAndCacheSurfacesForViewport.ts
Show resolved
Hide resolved
packages/tools/src/stateManagement/segmentation/helpers/clipAndCacheSurfacesForViewport.ts
Show resolved
Hide resolved
Context
Add the converters for
Labelmap to Contour
CleanShot.2024-02-12.at.08.57.09.mp4
Surface to Contour
CleanShot.2024-02-12.at.08.58.00.mp4
Changes & Results
Left to do
Testing
Checklist
PR
semantic-release format and guidelines.
Code
[] My code has been well-documented (function documentation, inline comments,
etc.)
[] I have run the
yarn build:update-apito update the API documentation, and havecommitted the changes to this PR. (Read more here https://www.cornerstonejs.org/docs/contribute/update-api)
Public Documentation Updates
additions or removals.
Tested Environment