Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Combine polyline interpolation breaks annotation state data #1079

Merged
merged 11 commits into from
Feb 20, 2024

Conversation

wayfarer3130
Copy link
Collaborator

@wayfarer3130 wayfarer3130 commented Feb 13, 2024

Context

If the list returned by getAnnotations is modified, it directly affects the underlying data object, breaking further interpolation.

Also fixes [#1091]

Changes & Results

Fixed the interpolation retrieve check to take a copy of the data returned from getAnnotations.

Testing

Create two spline interpolations, one slice apart. Combine an annotation. The original annotations shouldn't go blank.

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] "OS:
  • [] "Node version:
  • [] "Browser:

Copy link

netlify bot commented Feb 13, 2024

Deploy Preview for cornerstone-3d-docs ready!

Name Link
🔨 Latest commit 47131dd
🔍 Latest deploy log https://app.netlify.com/sites/cornerstone-3d-docs/deploys/65ccd95e535cfa00083a35e6
😎 Deploy Preview https://deploy-preview-1079--cornerstone-3d-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@wayfarer3130
Copy link
Collaborator Author

@lscoder - I've responded to both your comments. If that is ok, could you approve it and I will merge? The defect is currently corrupting internal annotation state, so I'd like to get it this far.

@wayfarer3130 wayfarer3130 merged commit 58efa2d into main Feb 20, 2024
9 checks passed
@wayfarer3130 wayfarer3130 deleted the fix/combine-polyline-interpolation branch February 20, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants