fix(annotations): Ensure viewports re-render for annotation drawing #1083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cornerstone-3d-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
sedghi
approved these changes
Feb 14, 2024
sedghi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
In some cases the viewports are not re-rendered making it impossible to draw annotations.
Changes & Results
Updated
triggerAnnotationRenderresponsible for "scheduling" a render call using RAF to make sure that even when an event listener adds a viewport back to theneedsRenderlist it can reschedule a new render call instead of getting blocked.Testing
Just open some examples such as Spline Contour Segmentation Advanced or Livewire Contour Segmentation and try to add annotations to coronal or sagittal viewpots.