Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tools): safely access handle points #1739

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

ramonemiliani93
Copy link
Contributor

@ramonemiliani93 ramonemiliani93 commented Jan 8, 2025

Context

Fixes #1738

Safely access the handle when not present on the contour annotation.

Changes & Results

Added check to handles and use empty list in case not present.

Testing

Checklist

PR

  • My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

Public Documentation Updates

  • The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] "OS:
  • [] "Node version:
  • [] "Browser:

Copy link

stackblitz bot commented Jan 8, 2025

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

netlify bot commented Jan 8, 2025

Deploy Preview for cornerstone-3d-docs ready!

Name Link
🔨 Latest commit 0bf7c60
🔍 Latest deploy log https://app.netlify.com/sites/cornerstone-3d-docs/deploys/677eabdfeefbb5000875d023
😎 Deploy Preview https://deploy-preview-1739--cornerstone-3d-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sedghi sedghi merged commit 9fe63af into cornerstonejs:main Jan 9, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] updateContourPolyline fails when handles not present
2 participants