Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stack viewport memory problem #491

Open
zhoualibaba opened this issue Mar 17, 2023 · 15 comments
Open

Stack viewport memory problem #491

zhoualibaba opened this issue Mar 17, 2023 · 15 comments

Comments

@zhoualibaba
Copy link

6026514da3941ca34b5d9023ec7fa3eb.mp4

@sedghi I have tried two ways to solve this bug. 1, Change the Google Chrome to the Chromium; 2, Seperate the multiple frames in one dcm file into a set of dcm files for each frame. The first way can solve the bug for most series, but if the frames count is too large (ie. 600+) the website will still crash. The second way can solve all the problems but I have to waste a lot of time to seperate the file.

@zhoualibaba
Copy link
Author

Sorry about the last issue.
I used to think it was the same problem

@sedghi
Copy link
Member

sedghi commented Mar 17, 2023

so does the problem happen when you use something else? like Scroll through wheel? or our stackScroll tool?

@zhoualibaba
Copy link
Author

This problem also happens when I use the stackScroll tool.

@sedghi
Copy link
Member

sedghi commented Mar 17, 2023

Is your data annonymized and whether you can share it?

@zhoualibaba
Copy link
Author

zhoualibaba commented Mar 20, 2023

We created a dicom for testing.
You can try it in“https://www.cornerstonejs.org/live-examples/local.html"
185_test.zip

@sedghi
Copy link
Member

sedghi commented Mar 21, 2023

Is this expected? What is the desired rendering? and what is the problem?
image

@zhoualibaba
Copy link
Author

zhoualibaba commented Mar 22, 2023

20230322-093232.mp4

Thanks for your quick response, and what you displayed is correct. This is an artificial 3D dicom file with multiple frames (One dicom file with dimension of 512 * 512 * 185). when you use the CINE or stackScroll tool using google chrome browser in windows, the memory leak issue would occur, as the above video shows. Have you used CINE or stackScroll tool to vusualize the file and checked your computer memory at the same time?

For your information, the memory leak issue disappeared when we use multiple 2D dicom files (185 2D dicom files, each dicom with dimension of 512 * 512) instead of one 3D dicom (512 * 512 * 185). As we mentioned before, there are temporary 2 ways that we tried to solve the issue, (1) Use the Chromium instead of the common google chrome; (2) Seperate one dicom files into a set of 2D dcm files.

@sedghi
Copy link
Member

sedghi commented Mar 22, 2023

Before further investigation, what do you mean by if you use Chromium, Do you mean Google Chrome Canary (the yellow logo?)

@zhoualibaba
Copy link
Author

zhoualibaba commented Mar 22, 2023

The Chromium is the open source browser with the same core with Google Chrome, the color of Chromium logo is blue.
image

@sedghi
Copy link
Member

sedghi commented Mar 22, 2023

So if that is fixed there, I expect chrome to fix the problem in the next release

@zhoualibaba
Copy link
Author

The Chromium can solve the bug for most series, but if the frames count is too large (ie. 600+) the website will still crash. I do not think that the Chromium solved this problem totally.

@zhoualibaba
Copy link
Author

I tried to seperate the multiple frames in one dcm file into a set of dcm files for each frame. This action do solve this problem, so I think the data loading of the volume dicom with multiple frames should be modified to be as the same as that of the the seperated dicoms in your architecture.

@tblock79
Copy link

tblock79 commented Apr 8, 2023

We experience the identical problem. Different browsers crash at different times (Firefox tends to crash a bit later), but they all do eventually. So, I don't think that a fix has been added to Chromium. I assume that there is some kind of memory leak related to the multi-frame loader (we use DICOM multi-frame images to reduce the transfer overhead).

@tblock79
Copy link

This PR actually solves the problem, at least for us (so it seems to originate from the WADO loader):
cornerstonejs/cornerstoneWADOImageLoader#454
Would be great if this could be merged into the main branch.

@daker
Copy link
Contributor

daker commented Dec 17, 2024

@zhoualibaba is this issue still relevant ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants