Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: MIP jump to image click #645

Merged
merged 3 commits into from
Jun 12, 2023
Merged

fix: MIP jump to image click #645

merged 3 commits into from
Jun 12, 2023

Conversation

wayfarer3130
Copy link
Collaborator

@wayfarer3130 wayfarer3130 commented Jun 8, 2023

Context

The MIP jump to image on click tool directly used viewportId's, but these aren't stable in CS3D because they get updated when the viewport gets a new display set or changes size in certain ways. Instead, this tool is switched to use a new concept pt axial

Changes & Results

Added viewport categories to the viewport options and a getViewportsInCategory to allow getting all the categorized viewports. That allows getting a set of viewports by some common condition.

Testing

Run the updated OHIF build containing the settings for the viewport categories or run the mipJumpToClick example
On mipJumpToClick, use the right panel to click on to navigate

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] "OS:
  • [] "Node version:
  • [] "Browser:

@netlify
Copy link

netlify bot commented Jun 8, 2023

Deploy Preview for cornerstone-3d-docs ready!

Name Link
🔨 Latest commit 7a76293
🔍 Latest deploy log https://app.netlify.com/sites/cornerstone-3d-docs/deploys/64876ef7a4c55e0009052eb6
😎 Deploy Preview https://deploy-preview-645--cornerstone-3d-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@wayfarer3130 wayfarer3130 force-pushed the fix/mip-click-to-navigate branch from defe78f to e50537e Compare June 12, 2023 19:14
@wayfarer3130 wayfarer3130 requested a review from sedghi June 12, 2023 19:17
@sedghi sedghi merged commit d81d583 into main Jun 12, 2023
@wayfarer3130 wayfarer3130 deleted the fix/mip-click-to-navigate branch January 22, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants