Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(multiframe): transfer only portion of data for multiframe to worker #652

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

sedghi
Copy link
Member

@sedghi sedghi commented Jun 13, 2023

Context

cornerstonejs/cornerstoneWADOImageLoader#454

Seems like for multiframe in wadouri, there is a huge performance problem and sometimes a out of memory in windows. It is solved by copying only the portion of the data that is needed to the worker.

Todo

There might be an optimization using SharedArrayBuffer to get the view out of the original buffer without copy but we will take a look into that later

Changes & Results

Testing

Try the local example with this data https://github.com/emelalkim/sampledata/releases/tag/large_multiframe

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] "OS:
  • [] "Node version:
  • [] "Browser:

@netlify
Copy link

netlify bot commented Jun 13, 2023

Deploy Preview for cornerstone-3d-docs ready!

Name Link
🔨 Latest commit 081c472
🔍 Latest deploy log https://app.netlify.com/sites/cornerstone-3d-docs/deploys/6487d69c1b6abd0008120ff8
😎 Deploy Preview https://deploy-preview-652--cornerstone-3d-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sedghi sedghi merged commit aaf94ea into main Jun 13, 2023
@sedghi sedghi deleted the multiframe-fix branch August 2, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant