fix(multiframe): transfer only portion of data for multiframe to worker #652
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
cornerstonejs/cornerstoneWADOImageLoader#454
Seems like for multiframe in wadouri, there is a huge performance problem and sometimes a out of memory in windows. It is solved by copying only the portion of the data that is needed to the worker.
Todo
There might be an optimization using SharedArrayBuffer to get the view out of the original buffer without copy but we will take a look into that later
Changes & Results
Testing
Try the
local
example with this data https://github.com/emelalkim/sampledata/releases/tag/large_multiframeChecklist
PR
semantic-release format and guidelines.
Code
[] My code has been well-documented (function documentation, inline comments,
etc.)
[] I have run the
yarn build:update-api
to update the API documentation, and havecommitted the changes to this PR. (Read more here https://www.cornerstonejs.org/docs/contribute/update-api)
Public Documentation Updates
additions or removals.
Tested Environment