Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(BaseVolumeViewport): when the volume actors are explicitly set, reset the inverted flag too #756

Merged

Conversation

jbocce
Copy link
Collaborator

@jbocce jbocce commented Aug 28, 2023

Context

Addresses OHIF issue 3485

Changes & Results

When the BaseVolume actors are explicitly set, reset the inverted flag too.

Testing

Once this PR is merged and CS3D is released and OHIF is (re)linked to the CS3D release test OHIF issue 3485

Checklist

PR

  • My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

Public Documentation Updates

  • The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • "OS: Windows 11
  • "Node version: 16.14.0
  • "Browser: Chrome 116.0.5845.111

@netlify
Copy link

netlify bot commented Aug 28, 2023

Deploy Preview for cornerstone-3d-docs ready!

Name Link
🔨 Latest commit 7439e85
🔍 Latest deploy log https://app.netlify.com/sites/cornerstone-3d-docs/deploys/64ecf78dcc1d970008d25cfb
😎 Deploy Preview https://deploy-preview-756--cornerstone-3d-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jbocce jbocce requested a review from sedghi August 28, 2023 19:38
@sedghi sedghi merged commit 2258093 into cornerstonejs:main Aug 29, 2023
@jbocce jbocce deleted the fix/reset-invert-when-setting-volumes branch August 31, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants