Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(VolumeViewport): Add getImageIds to volume viewport #758

Merged

Conversation

jlopes90
Copy link
Contributor

@jlopes90 jlopes90 commented Aug 29, 2023

Context

This adds the getImageIds method to the VolumeViewport.

Changes & Results

Added getImageIds to the VolumeViewport class, now you can get image ids for the volume viewport.

Testing

https://deploy-preview-758--cornerstone-3d-docs.netlify.app/live-examples/volumebasic

cornerstone.getRenderingEngines()[0].getViewports()[0].getImageIds();

Checklist

PR

  • My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

Public Documentation Updates

  • The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • "OS: Windows 10
  • "Node version: 18.12.0
  • "Browser: Chrome Version 116.0.5845.111 (Official Build) (64-bit)

@netlify
Copy link

netlify bot commented Aug 29, 2023

Deploy Preview for cornerstone-3d-docs ready!

Name Link
🔨 Latest commit d3344f6
🔍 Latest deploy log https://app.netlify.com/sites/cornerstone-3d-docs/deploys/64ee2b9a476ebe00085b0e06
😎 Deploy Preview https://deploy-preview-758--cornerstone-3d-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@sedghi sedghi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. see my comments

Copy link
Member

@sedghi sedghi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. This is a great contribution, thanks a lot!

@sedghi sedghi merged commit 6c430c7 into cornerstonejs:main Aug 29, 2023
@jlopes90 jlopes90 deleted the feat/getImageIds-to-volume-viewport branch August 30, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants