fix(modifier key): reset modifier keys when browser tab loses focus/is hidden #759
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Fixes #733.
Changes & Results
In
packages\tools\src\eventListeners\keyboard\keyDownListener.ts
, reset the modifier key whenever the browser tab is 'hidden' (i.e. loses focus). Prior to this PR, the modifier key for changing tab (e.g. Ctrl) or app (e.g. Alt) focus would remain in the modifier key state and was never cleared until a subsequent key-up event.Testing
First and foremost, ensure issue #733 is resolved.
Test A:
doubleClickWithStackAnnotationTools
example.Ctrl-tab
orAlt-tab
to change the tab/app focus.Test B:
modifierkeys
example.Ctrl-tab
orAlt-tab
to change the tab/app focus.Checklist
PR
semantic-release format and guidelines.
Code
My code has been well-documented (function documentation, inline comments,
etc.)
I have run the
yarn build:update-api
to update the API documentation, and havecommitted the changes to this PR. (Read more here https://www.cornerstonejs.org/docs/contribute/update-api)
Public Documentation Updates
additions or removals.
Tested Environment