Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/cine black images #761

Merged
merged 21 commits into from
Sep 12, 2023
Merged

Fix/cine black images #761

merged 21 commits into from
Sep 12, 2023

Conversation

wayfarer3130
Copy link
Collaborator

@wayfarer3130 wayfarer3130 commented Aug 30, 2023

Context

If the image load time is sufficiently slow, then the frame will never be displayed before the next frame is requested, and the CINE viewport goes black. This change ensures that every frame is displayed, not continuing to the next frame until a frame is displayed or the retries limit is hit.

Changes & Results

Ensures that CINE plays every frame, waiting till it is available to be rendered.

Testing

Hard to test without a very slow back end. Play CINE against a slow/large dataset like the visible light human dataset. Previously, the images would go black.

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] "OS:
  • [] "Node version:
  • [] "Browser:

@netlify
Copy link

netlify bot commented Aug 30, 2023

Deploy Preview for cornerstone-3d-docs ready!

Name Link
🔨 Latest commit 1c8ba3f
🔍 Latest deploy log https://app.netlify.com/sites/cornerstone-3d-docs/deploys/64fb7204db270c0008bb13d4
😎 Deploy Preview https://deploy-preview-761--cornerstone-3d-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sedghi
Copy link
Member

sedghi commented Sep 7, 2023

is this for the case where framerate is slow or fast? I thought it is for fast

@sedghi sedghi merged commit b110bda into main Sep 12, 2023
@wayfarer3130 wayfarer3130 deleted the fix/cine-black-images branch January 22, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants