feat(brush size): enable specifying brush size for specific tool #780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cornerstone-3d-docs canceled.
|
jbocce
reviewed
Sep 12, 2023
| @@ -276,6 +276,9 @@ function _setLabelmapColorAndOpacity( | |||
| isActiveLabelmap | |||
| ); | |||
|
|
|||
| // Todo: the below loop probably can be optimized so that we don't hit it | |||
| // unless a config has chaged. Right now we get into the following loop | |||
jbocce
reviewed
Sep 12, 2023
| @@ -10,7 +10,7 @@ export type ThresholdInformation = { | |||
| upper: number; | |||
| }; | |||
|
|
|||
| export default function getBrushToolInstances(toolGroupId) { | |||
| export default function getBrushToolInstances(toolGroupId, toolName) { | |||
There was a problem hiding this comment.
I think there are other calls that need to include this new parameter. I believe the unit tests are also failing because of this.
jbocce
reviewed
Sep 12, 2023
| @@ -6,15 +6,16 @@ import getBrushToolInstances from './utilities'; | |||
|
|
|||
| export function setBrushSizeForToolGroup( | |||
| toolGroupId: string, | |||
| brushSize: number | |||
| brushSize: number, | |||
| toolName?: string | |||
There was a problem hiding this comment.
Maybe the tools api docs need updating?
jbocce
requested changes
Sep 12, 2023
jbocce
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Changes & Results
Testing
Checklist
PR
semantic-release format and guidelines.
Code
[] My code has been well-documented (function documentation, inline comments,
etc.)
[] I have run the
yarn build:update-apito update the API documentation, and havecommitted the changes to this PR. (Read more here https://www.cornerstonejs.org/docs/contribute/update-api)
Public Documentation Updates
additions or removals.
Tested Environment