feat(rendering): HTJ2K Progressive Display on main branch #879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cornerstone-3d-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
wayfarer3130
commented
Nov 10, 2023
| function callLoadStatusCallback(evt) { | ||
| // TODO: probably don't want this here | ||
| // if it is not a cached image or volume | ||
| if (!cachedImage && !(cachedVolume && cachedVolume.volume !== this)) { |
There was a problem hiding this comment.
@sedghi - this line was wrong previously and for a cached image response which is still waiting to receive data, it
won't got through handle from cache code, which mucks up the display. I believe the stack/volume caches are a bit more efficient and allow the stack cache to get started but not completed before the volume cache checks.
There was a problem hiding this comment.
I think i know what was happening, it is reusing the image from stack viewport and that has an issue as you saw
…/feat/htj2k-progressive
sedghi
approved these changes
Nov 14, 2023
sedghi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge of HTJ2K/Progressive display from Beta
Context
Adds HTJ2K display to the main branch.
Changes & Results
Testing
Checklist
PR
semantic-release format and guidelines.
Code
[] My code has been well-documented (function documentation, inline comments,
etc.)
[] I have run the
yarn build:update-apito update the API documentation, and havecommitted the changes to this PR. (Read more here https://www.cornerstonejs.org/docs/contribute/update-api)
Public Documentation Updates
additions or removals.
Tested Environment