fix(state manager): Make viewport-related data optional for annotation event #950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cornerstone-3d-docs canceled.
|
|
@sedghi @wayfarer3130 can you please review this one? |
sedghi
reviewed
Jan 8, 2024
packages/tools/src/stateManagement/annotation/FrameOfReferenceSpecificAnnotationManager.ts
Outdated
Show resolved
Hide resolved
sedghi
reviewed
Jan 8, 2024
sedghi
reviewed
Jan 8, 2024
sedghi
reviewed
Jan 8, 2024
packages/tools/src/stateManagement/annotation/FrameOfReferenceSpecificAnnotationManager.ts
Outdated
Show resolved
Hide resolved
sedghi
changed the title
sedghi
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The event was not being triggered by the FOR state manager
The annotation event is being used by the measurement service here and it's not required to have viewport-related data since it's being consumed without it. This change makes it optional.
Related PR: feat(SR): SCOORD3D point annotations support for stack viewport OHIF/Viewers#3857
Context
Changes & Results
Testing
Checklist
PR
semantic-release format and guidelines.
Code
[] My code has been well-documented (function documentation, inline comments,
etc.)
[] I have run the
yarn build:update-apito update the API documentation, and havecommitted the changes to this PR. (Read more here https://www.cornerstonejs.org/docs/contribute/update-api)
Public Documentation Updates
additions or removals.
Tested Environment