Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: condition default streaming value #973

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Conversation

baokeyu123
Copy link
Contributor

Context

For example, if streaming set false/0/null/'', false !== undefined is true.
I think this line of code should be changed to if (retrieveOptions.streaming) whether it is load or prefetch scenario.

Changes & Results

- if (retrieveOptions.streaming !== undefined) 
+ if (retrieveOptions.streaming) 

Testing

None

Checklist

PR

  • My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

Public Documentation Updates

  • The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • "OS:
  • "Node version:
  • "Browser:

Copy link

netlify bot commented Dec 25, 2023

Deploy Preview for cornerstone-3d-docs ready!

Name Link
🔨 Latest commit 8501192
🔍 Latest deploy log https://app.netlify.com/sites/cornerstone-3d-docs/deploys/6589635c8699a900087044c5
😎 Deploy Preview https://deploy-preview-973--cornerstone-3d-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sedghi sedghi requested a review from wayfarer3130 December 27, 2023 13:44
Copy link
Member

@sedghi sedghi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@sedghi sedghi merged commit e9edf3c into cornerstonejs:main Jan 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants