Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: _init function condition fault-tolerant in ScaleOverlayTool #991

Merged
merged 3 commits into from
Jan 11, 2024

Conversation

baokeyu123
Copy link
Contributor

Context

image

after i destroy toolgroup and destroy renderingEngine, i recreate new toolgroup and new renderingEngine with the same id(toolgroupId).this error would happen.

Changes & Results

- else if (this.editData.annotation.data.viewportId == viewport.id)
+ else if (this.editData.annotation && this.editData.annotation.data.viewportId == viewport.id)

Testing

None

Checklist

PR

  • My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

Public Documentation Updates

  • The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • "OS:
  • "Node version:
  • "Browser:

Copy link

netlify bot commented Jan 10, 2024

Deploy Preview for cornerstone-3d-docs ready!

Name Link
🔨 Latest commit ac0c5cf
🔍 Latest deploy log https://app.netlify.com/sites/cornerstone-3d-docs/deploys/659e7aa3567aad0008c07107
😎 Deploy Preview https://deploy-preview-991--cornerstone-3d-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sedghi sedghi merged commit f90d6c8 into cornerstonejs:main Jan 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants