Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(increase-coverage): weekly tests PR #1332

Merged
merged 20 commits into from
Jun 19, 2024
Merged

tests(increase-coverage): weekly tests PR #1332

merged 20 commits into from
Jun 19, 2024

Conversation

IbrahimCSAE
Copy link
Collaborator

@IbrahimCSAE IbrahimCSAE commented Jun 17, 2024

Context

This is a weekly tests PR

Changes

  • Converted all spec.js to spec.ts
  • Added simulateClicksOnEliminate utility, with an option to delay between clicks, useful for clicks that generate rendering operations like segmentation where a delay is needed

Tests

  • should render and allow usage of circle brush
  • should render and allow usage of circle eraser
  • should render and allow usage of sphere brush
  • should render and allow usage of sphere eraser
  • should render and allow usage of threshold circle
  • should render and allow usage of rectangle scissor
  • should render and allow usage of circle scissor
  • should render and allow usage of sephere scissor
  • should render and allow usage of eraser scissor
  • should render and allow usage of paint fill
  • surface segmentation representation for volume viewports

Results

image

Copy link

netlify bot commented Jun 17, 2024

Deploy Preview for cornerstone-3d-docs canceled.

Name Link
🔨 Latest commit f6a1075
🔍 Latest deploy log https://app.netlify.com/sites/cornerstone-3d-docs/deploys/667317268b59f0000844386d

@sedghi
Copy link
Member

sedghi commented Jun 18, 2024

WIP or can i review

@IbrahimCSAE IbrahimCSAE changed the title [WIP] tests(increase-coverage): weekly tests PR tests(increase-coverage): weekly tests PR Jun 18, 2024
@IbrahimCSAE IbrahimCSAE requested a review from sedghi June 18, 2024 02:54
Copy link
Member

@sedghi sedghi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks great

@IbrahimCSAE
Copy link
Collaborator Author

CI is failing so lets not merge until I fix this, not sure whats the cause yet since it passes locally

Copy link
Member

@sedghi sedghi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, great stuff

@sedghi sedghi merged commit d6d099a into main Jun 19, 2024
15 checks passed
@sedghi sedghi mentioned this pull request Jul 9, 2024
17 tasks
@IbrahimCSAE IbrahimCSAE deleted the test/weekly-test-pr-3 branch January 22, 2025 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants