[Bug] Drag unselected active tool

[take5v]

Prerequisites

• Which version are you using? (Is it latest?)
• Are you reporting to the correct repository?
• Did you search existing issues? (Were any related?)

Description

Method _dragHandler should not be executed on an unselected active tool when dragging another selected tool.

Steps to Reproduce the issue

Reproduce steps for OHIF viewer which uses csTools:

1. When I open the study: https://viewer.ohif.org/viewer/1.3.6.1.4.1.25403.345050719074.3824.20170125113417.1
2. Then I add Length tool measurement
3. Then I add Angle tool measurement (Angle tool is still active)
4. Then I hover under the Length tool measurement and drag it.
5. I see the error in console: "Uncaught TypeError: data.handles.middle is undefined"

Expected behavior: (What you expected to happen)

_dragHandler method is not executed on an unselected active tool. No exceptions are raised

Actual behavior: (What actually happened)

Exception is raised:
Uncaught TypeError: data.handles.middle is undefined
updateCachedStats https://viewer.ohif.org/app.bundle.255df793a2cc1b5f17cd.js:35460
_dragHandler https://viewer.ohif.org/app.bundle.255df793a2cc1b5f17cd.js:22401
triggerEvent https://viewer.ohif.org/app.bundle.255df793a2cc1b5f17cd.js:51153
onMouseMove https://viewer.ohif.org/app.bundle.255df793a2cc1b5f17cd.js:19981
mouseDown https://viewer.ohif.org/app.bundle.255df793a2cc1b5f17cd.js:20034
enable https://viewer.ohif.org/app.bundle.255df793a2cc1b5f17cd.js:20098
default https://viewer.ohif.org/app.bundle.255df793a2cc1b5f17cd.js:26101
dispatchEvent https://viewer.ohif.org/app.bundle.255df793a2cc1b5f17cd.js:53906
triggerEvent https://viewer.ohif.org/app.bundle.255df793a2cc1b5f17cd.js:58964
default https://viewer.ohif.org/app.bundle.255df793a2cc1b5f17cd.js:53481
_callee$ https://viewer.ohif.org/vendors~OHIFCornerstoneViewport.bundle.545b6e0833d68ab30b81.js:9129
tryCatch https://viewer.ohif.org/app.bundle.255df793a2cc1b5f17cd.js:179670
invoke https://viewer.ohif.org/app.bundle.255df793a2cc1b5f17cd.js:179896
method https://viewer.ohif.org/app.bundle.255df793a2cc1b5f17cd.js:179722
asyncGeneratorStep https://viewer.ohif.org/vendors~OHIFCornerstoneViewport.bundle.545b6e0833d68ab30b81.js:936
_next https://viewer.ohif.org/vendors~OHIFCornerstoneViewport.bundle.545b6e0833d68ab30b81.js:958
_asyncToGenerator https://viewer.ohif.org/vendors~OHIFCornerstoneViewport.bundle.545b6e0833d68ab30b81.js:965
_asyncToGenerator https://viewer.ohif.org/vendors~OHIFCornerstoneViewport.bundle.545b6e0833d68ab30b81.js:954
componentDidMount https://viewer.ohif.org/vendors~OHIFCornerstoneViewport.bundle.545b6e0833d68ab30b81.js:9187
ik https://viewer.ohif.org/app.bundle.255df793a2cc1b5f17cd.js:189199
unstable_runWithPriority https://viewer.ohif.org/app.bundle.255df793a2cc1b5f17cd.js:189275
fg https://viewer.ohif.org/app.bundle.255df793a2cc1b5f17cd.js:189068
Yj https://viewer.ohif.org/app.bundle.255df793a2cc1b5f17cd.js:189192
Lj https://viewer.ohif.org/app.bundle.255df793a2cc1b5f17cd.js:189171
ig https://viewer.ohif.org/app.bundle.255df793a2cc1b5f17cd.js:189069
unstable_runWithPriority https://viewer.ohif.org/app.bundle.255df793a2cc1b5f17cd.js:189275
fg https://viewer.ohif.org/app.bundle.255df793a2cc1b5f17cd.js:189068
ig https://viewer.ohif.org/app.bundle.255df793a2cc1b5f17cd.js:189069
jg https://viewer.ohif.org/app.bundle.255df793a2cc1b5f17cd.js:189068
Rg https://viewer.ohif.org/app.bundle.255df793a2cc1b5f17cd.js:189162
enqueueSetState https://viewer.ohif.org/app.bundle.255df793a2cc1b5f17cd.js:189081
setState https://viewer.ohif.org/app.bundle.255df793a2cc1b5f17cd.js:188491
setStateFromProps https://viewer.ohif.org/OHIFCornerstoneViewport.bundle.70a492acfbde443762d7.js:394

[ricardonava]

@take5v Were you able to find a solution to this problem?

[take5v]

@ricardonava Not yet.

[ricardonava]

@take5v Oh well, I'm actively looking for a solution to this, let you know if I find something.