Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msvcr120.dll is missing in the final JRE distribution for Windows #131

Closed
qbert1984 opened this issue May 24, 2019 · 9 comments
Closed

msvcr120.dll is missing in the final JRE distribution for Windows #131

qbert1984 opened this issue May 24, 2019 · 9 comments
Assignees
Labels
bug Something isn't working windows Windows-related issue
Milestone

Comments

@qbert1984
Copy link

The final distribution of Corretto 8.212 for Windows (build 1.8.0_212-b04) is missing some dlls in comparison to the Oracle distribution. In particular I need the msvcr120.dll in the jre/bin folder to execute a Windows service installation. Also the msvcp120.dll isn't contained - maybe there are even more.

similar to issue #69

@EricEdens
Copy link
Contributor

Thanks for the report -- we'll take a look and get back soon.

@EricEdens
Copy link
Contributor

@qbert1984 -- Can you post a minimal reproduction program? It should be a single .java file that we can compile and run on our side.

@qbert1984
Copy link
Author

qbert1984 commented May 29, 2019

Hi Eric, I don't know what this should prove. I need the DLL in some way but it is missing - which is a fact. Is there a fundamental problem on including it? Would also be acceptable but maybe you could explain it then... and also why there is a discrepancy regarding DLLs between Corretto and Oracle.

Edit: To clarify the confusion: I don't get to the point running Java program code. We deliver JRE inside of a Windows installer. There are running several commandline scripts to install e.g. PostgreSQL as a service (this process requires the msvcr120.dll). The DLL is normally (in case of Oracle) delivered by the JRE and we rely on this.

@jguo11 jguo11 added this to the 8u222 milestone Jun 24, 2019
@TianminShi
Copy link
Contributor

Hi @qbert1984, just want to let you know we are working on this issue. however I do need a quick anwser from you. which version of Oracle sdk are you using which contains msvcr120.dll ?

@qbert1984
Copy link
Author

Hi! It was the Oracle JDK 1.8.0_141

@TianminShi TianminShi assigned TianminShi and unassigned yoroto Jul 17, 2019
@TianminShi TianminShi added bug Something isn't working windows Windows-related issue labels Jul 17, 2019
@TianminShi
Copy link
Contributor

@qbert1984
Copy link
Author

Sorry, but I cannot verify this. The dll is still missing in the latest build.

@TianminShi
Copy link
Contributor

sorry for not giving enough explaination earlier. here are the reasons I consider this issue closed.

about two years ago (24 Jul 2017) openjfx upgrade their runtime dependencies from VS2013 to VS2017 Which means it depends on a set of new DLLS include (concrt140, vcruntime140, msvcp140) which are the replacement for msvcr120 and msvcp120. msvcr120 and msvcp120 are no longer dependencies of the latest openjfx, so it does not make sense to include them in Corretto-8. and with the latest release of Corretto-8(https://github.com/corretto/corretto-8/releases/tag/8.222.10.3) we do included the new set of DLLs which are necessary for openjfx to function.

also want to point out that there are not discrepancy between the latest oracle jdk1.8.0_221 and Corretto-8(https://github.com/corretto/corretto-8/releases/tag/8.222.10.3) regarding to vc++ Redistributable. they both don't include msvcr120 and msvcp120. you would have the exactlly same problem if you update to the latest oracle JDK. so if you have other application reqires msvcr120.dll, I think the best ways forward are either bundle it with the application or include it in your installler. hope it helps.

here are two links from openjfx source which point out the difference on runtime dependencies:
latest
http://hg.openjdk.java.net/openjfx/8u/rt/file/tip/modules/graphics/src/main/java/com/sun/javafx/tk/Toolkit.java#l154
older version:
http://hg.openjdk.java.net/openjfx/8u/rt/file/f64b2c61fc25/modules/graphics/src/main/java/com/sun/javafx/tk/Toolkit.java#l147

@qbert1984
Copy link
Author

Thanks, Tianmin, for the explanation. I'll give it a try

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working windows Windows-related issue
Projects
None yet
Development

No branches or pull requests

5 participants