Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing TypeScript typings for the published npm package #88

Open
whiite opened this issue Mar 1, 2021 · 2 comments
Open

Missing TypeScript typings for the published npm package #88

whiite opened this issue Mar 1, 2021 · 2 comments

Comments

@whiite
Copy link

whiite commented Mar 1, 2021

Hi, I noticed you've recently ported the JS version to TypeScript and can see you have a types file in the repo but it seems to be missing in the published package on npm for version 2 so the types can't currently be used without downloading the types file separately.

@cosinekitty
Copy link
Owner

@whiite Thank you for reporting this issue. We are grateful when people take the time to let us know something needs improvement.

@matheo Thank you for fixing the issue.

I committed one extra change in a8c970b to update the npm package version to 2.0.1 in documentation.json.

The npm package 2.0.1 now contains the file astronomy.d.ts.

@cosinekitty
Copy link
Owner

Thanks to help from @vpctorr in #329 and #330, the npm package of Astronomy Engine version 2.1.19 contains some more fixes for how TypeScript types are exported. I mention here in this issue in case anyone with a TypeScript project that depends on Astronomy Engine would like to help upgrade and re-test. Please report any problems here. Thanks in advance!

@cosinekitty cosinekitty reopened this Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants