Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: Best way to avoid the 'not current revision' message? #16

Open
Chris--S opened this issue Feb 20, 2013 · 6 comments
Open

Discussion: Best way to avoid the 'not current revision' message? #16

Chris--S opened this issue Feb 20, 2013 · 6 comments

Comments

@Chris--S
Copy link
Contributor

When the latest version is not approved and non-approved versions (drafts) are hidden to read-only users, DokuWiki will show "this is not the latest revision" message, which isn't particularly helpful.

Does it make sense to request a new event in DokuWiki around that message?
TPL_OLDREVISION_ALERT

And a config option in this plugin to hide or replace that message.

@splitbrain
Copy link
Member

I wonder if the plugin could simply overwrite the $lang entry for that message. Or this message in a .txt file?

@Chris--S
Copy link
Contributor Author

Its a .txt file "showrev"[1]. I think its perfectly valid to show the message when you are truly looking at an old revision. Its only a problem for a reader viewing the latest approved version when there is a later unapproved rev.

Were you meaning on the fly rewriting of that message?
In this case 'showrev' could be moved into the $lang strings, its only a single line.
It wouldn't be a bad idea to add an event inside p_locale_xhtml(). I have an idea for a language plugin allow substitution of language strings or locale txt files without impacting on upgrades.

In this case, maybe the neatest solution would be to wrap the p_locale_xhtml('showrev') in a <div class="oldrev_alert"> to allow for css control.

[1] https://github.com/splitbrain/dokuwiki/blob/master/inc/html.php#L243

@Finkregh
Copy link

any idea how to properly remove/hide this message?

@mccannjg
Copy link

mccannjg commented Apr 5, 2016

Had to add these changes manually - how come they are not committed yet?

@3615pipou
Copy link

Any news on this problem ?

@racquetmaster
Copy link

This is still a problem for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants