Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore generic map and list wrappers for fast reflection #15

Open
aaronc opened this issue Aug 18, 2021 · 2 comments
Open

Explore generic map and list wrappers for fast reflection #15

aaronc opened this issue Aug 18, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@aaronc
Copy link
Member

aaronc commented Aug 18, 2021

As a follow-up to #8, let's explore a way to have generic map and list wrapper types rather than doing codegen for each of them.

@technicallyty technicallyty self-assigned this Aug 25, 2021
@technicallyty technicallyty added the enhancement New feature or request label Aug 25, 2021
@technicallyty
Copy link
Contributor

we can do lists by just using []interface{} but i believe this would require a good amount of reflection - is speed not as important for this or should we explore a different way to handle generic list?

@fdymylja
Copy link
Contributor

fdymylja commented Sep 1, 2021

Considering that it might need to respect mutability constraint the only way we could do that is with heavy reflection, which would harm performance by 10 times I think, which would kill the purpose of having fast reflection.

I'd go with the golang generics path, once available (should come by end of 2021 start of 2022).

@technicallyty technicallyty removed their assignment Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants