Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more test vectors to secp256k1 cgo #11343

Closed
4 tasks
Tracked by #14883
tac0turtle opened this issue Mar 9, 2022 · 1 comment · Fixed by #14756
Closed
4 tasks
Tracked by #14883

add more test vectors to secp256k1 cgo #11343

tac0turtle opened this issue Mar 9, 2022 · 1 comment · Fixed by #14756
Assignees
Labels

Comments

@tac0turtle
Copy link
Member

Summary

add more test vectors to secp256k1 cgo implementation #11298 (review)


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@ValarDragon
Copy link
Contributor

Its an issue for both cgo and native go! This is the only test vector against external libraries for all the tests: https://github.com/cosmos/cosmos-sdk/blob/master/crypto/keys/secp256k1/secp256k1_test.go#L29-L35

We should add more test vectors directly here, so we can fearlessly integrate changes into the go code and the cgo in the future, and mitigate concerns of things breaking from standards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants