Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider renaming container.AutoGroupType #11935

Closed
Tracked by #11899
aaronc opened this issue May 11, 2022 · 6 comments · Fixed by #11978
Closed
Tracked by #11899

Consider renaming container.AutoGroupType #11935

aaronc opened this issue May 11, 2022 · 6 comments · Fixed by #11978
Assignees

Comments

@aaronc
Copy link
Member

aaronc commented May 11, 2022

This seems unintuitive. container.OnePerModuleType is clearer. Maybe container.AutoGroupType can become container.ManyPerContainerType or something?

@aaronc aaronc changed the title Rename container.AutoGroupType Consider renaming container.AutoGroupType May 11, 2022
@tac0turtle tac0turtle moved this to 📝 Todo in Cosmos-SDK May 11, 2022
@facundomedica facundomedica self-assigned this May 17, 2022
@facundomedica
Copy link
Member

facundomedica commented May 17, 2022

While I was studying the container package I saw this issue :) (nothing fancy, just a quick replace and tests still run)

@facundomedica facundomedica moved this from 📝 Todo to 👀 Needs Review in Cosmos-SDK May 17, 2022
@aaronc
Copy link
Member Author

aaronc commented May 17, 2022

Does this seem like an improvement to you? Is it easier to under?

@facundomedica
Copy link
Member

Yes, my thought is that AutoGroup describes "what happens to it" while ManyPerContainer describes "what you can do with it" which IMO is what you want to know when you are implementing it; so you don't really care how it's being handled internally.
That being said, I'm still wrapping my head around the container package and how to implement it, so I might be very wrong ☝️

@aaronc
Copy link
Member Author

aaronc commented May 17, 2022

What about simply ManyType?

@facundomedica
Copy link
Member

facundomedica commented May 18, 2022

I gave this some thought and I think ManyPerContainer works better, at least it's more consistent with OnePerModule; just Many sounds too broad. If you agree feel free to merge the PR, I was holding back that until we come to a conclusion

@aaronc
Copy link
Member Author

aaronc commented May 18, 2022

Sounds good let's merge

Repository owner moved this from 👀 Needs Review to 👏 Done in Cosmos-SDK May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants