-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider renaming container.AutoGroupType #11935
Comments
While I was studying the container package I saw this issue :) (nothing fancy, just a quick replace and tests still run) |
Does this seem like an improvement to you? Is it easier to under? |
Yes, my thought is that |
What about simply |
I gave this some thought and I think |
Sounds good let's merge |
This seems unintuitive.
container.OnePerModuleType
is clearer. Maybecontainer.AutoGroupType
can becomecontainer.ManyPerContainerType
or something?The text was updated successfully, but these errors were encountered: