Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better error for unexported fields with container.In/Out #11943

Closed
Tracked by #11899
aaronc opened this issue May 11, 2022 · 2 comments
Closed
Tracked by #11899

Better error for unexported fields with container.In/Out #11943

aaronc opened this issue May 11, 2022 · 2 comments
Assignees
@JeancarloBarrios

Comments

@aaronc
Copy link
Member

aaronc commented May 11, 2022 •
edited
Loading

container.In and container.Out allow using struct fields for dependency provide inputs and outputs.

If an unexported field is in one of these structs, the container still tries to use it and go just panics.

The container should report an error and tell the user which field is the problem. We could consider just skipping unexported fields, but this might lead to more unexpected behavior. Probably better to keep the current behavior but improve the error message.
@aaronc aaronc mentioned this issue May 11, 2022
Closed
81 tasks
@aaronc aaronc changed the title Better handling of unexported fields with container.In/Out Better error for unexported fields with container.In/Out May 11, 2022
@tac0turtle tac0turtle moved this to 📝 Todo in Cosmos-SDK May 11, 2022
@JeancarloBarrios JeancarloBarrios self-assigned this Jul 27, 2022
@JeancarloBarrios JeancarloBarrios moved this from 📝 Todo to 💪 In Progress in Cosmos-SDK Aug 1, 2022
@JeancarloBarrios JeancarloBarrios moved this from 💪 In Progress to 👀 Needs Review in Cosmos-SDK Aug 1, 2022
@JeancarloBarrios
Copy link
Contributor

PR: #12786

1 similar comment
@JeancarloBarrios
Copy link
Contributor

PR: #12786

Repository owner moved this from 👀 Needs Review to 👏 Done in Cosmos-SDK Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JeancarloBarrios JeancarloBarrios

Labels
None yet
Projects
Cosmos-SDK
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@aaronc @JeancarloBarrios @tac0turtle