Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate x/bank to app wiring #12083

Closed
2 of 3 tasks
Tracked by #11899
tac0turtle opened this issue May 30, 2022 · 5 comments
Closed
2 of 3 tasks
Tracked by #11899

migrate x/bank to app wiring #12083

tac0turtle opened this issue May 30, 2022 · 5 comments
Assignees
@tac0turtle

Comments

@tac0turtle
Copy link
Member

tac0turtle commented May 30, 2022 •
edited
Loading

  • add app wiring functions
  • decouple from simapp
  • add app.yaml to integration tests
@tac0turtle tac0turtle mentioned this issue May 30, 2022
Closed
81 tasks
@tac0turtle tac0turtle changed the title x/bank migrate x/bank to app wiring May 30, 2022
@tac0turtle tac0turtle moved this to 📝 Todo in Cosmos-SDK May 30, 2022
@tac0turtle tac0turtle moved this from 📝 Todo to 💪 In Progress in Cosmos-SDK May 30, 2022
@tac0turtle tac0turtle mentioned this issue Jun 1, 2022
Merged
19 tasks
Repository owner moved this from 💪 In Progress to 👏 Done in Cosmos-SDK Jun 1, 2022
@tac0turtle
Copy link
Member Author

Still missing decoupling from simapp, @aaronc should we include that into this process or leave it for later?

@tac0turtle tac0turtle reopened this Jun 2, 2022
Repository owner moved this from 👏 Done to 📝 Todo in Cosmos-SDK Jun 2, 2022
@aaronc
Copy link
Member

aaronc commented Jun 2, 2022

It depends on staking and genutil

@kocubinski
Copy link
Member

Still missing decoupling from simapp, @aaronc should we include that into this process or leave it for later?

Could you explain the success criteria for "decoupling from simapp"? Not clear to me.

@kocubinski
Copy link
Member

After speaking with @marbar3778 and @alexanderbez it's now clear that we're talking about dependencies in the simulation package, here "github.com/cosmos/cosmos-sdk/simapp/params

@tac0turtle tac0turtle moved this from 📝 Todo to 💪 In Progress in Cosmos-SDK Jun 3, 2022
@tac0turtle tac0turtle mentioned this issue Jun 14, 2022
Closed
19 tasks
@tac0turtle tac0turtle assigned tac0turtle and unassigned kocubinski Jun 14, 2022
@tac0turtle
Copy link
Member Author

closing as completed in relation to rewriting tests

Repository owner moved this from 💪 In Progress to 👏 Done in Cosmos-SDK Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tac0turtle tac0turtle

Labels
None yet
Projects
Cosmos-SDK
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: decouple bank from simapp cosmos/cosmos-sdk
3 participants
@aaronc @kocubinski @tac0turtle