Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetTxsEvent returns error if event type contains underscore. #13858

Closed
artemii235 opened this issue Nov 14, 2022 · 2 comments · Fixed by #13861
Closed

GetTxsEvent returns error if event type contains underscore. #13858

artemii235 opened this issue Nov 14, 2022 · 2 comments · Fixed by #13861
Assignees

Comments

@artemii235
Copy link

Summary of Bug

In our project, we use IRIS for atomic swaps support between Cosmos ecosystem and other chains. Recently, I have noticed that our tests started to fail after Iris testnet update to 1.4.0-rc1. Which in its turn bumped cosmos-sdk from 0.46.1 to 0.46.4. Iris HTLC module emits event types containing _ character: create_htlc, claim_htlc. Which is not allowed anymore after this #12474 PR was merged. The regex https://github.com/cosmos/cosmos-sdk/pull/12474/files#diff-53f84248611b4e705fd4106d3f6f46eed9258656b0b3db22bd56fdde5628cebdR47 should contain _ to make it work again.

Version

0.46.4+

Steps to Reproduce

Try using claim_htlc.id='2B925FC83A106CC81590B3DB108AC2AE496FFA912F368FE5E29BC1ED2B754F2C' events string with http://34.80.202.172:26657 IRIS node.

Expected result: it should return the transaction emitted the requested event.

Actual result: rpc error: code = InvalidArgument desc = invalid event; event claim_htlc.id='2B925FC83A106CC81590B3DB108AC2AE496FFA912F368FE5E29BC1ED2B754F2C' should be of the format: {eventType}.{eventAttribute}={value}: invalid request"

@artemii235
Copy link
Author

@alexanderbez Thanks for the fix! Is it going to be released soon?

@julienrbrt
Copy link
Member

@alexanderbez Thanks for the fix! Is it going to be released soon?

0.46.5 will contain the fix and should be released today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants