Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move prompt to client/v2 #17222

Closed
Tracked by #18580
julienrbrt opened this issue Jul 31, 2023 · 1 comment
Closed
Tracked by #18580

Move prompt to client/v2 #17222

julienrbrt opened this issue Jul 31, 2023 · 1 comment
Assignees
@JulianToledano
Labels
T: Client UX

Comments

@julienrbrt
Copy link
Member

The draft-proposal command introduced a Prompt (https://github.com/cosmos/cosmos-sdk/blob/701aaa8/x/gov/client/cli/prompt.go) helper, that prompts the user of each field.

We should move Prompt to client/v2 and use the scalar annotation instead of simple field matching for validating the fields.
Additionally, the Prompt should work recursively on the whole message.

ref: #15982 (comment)
@julienrbrt julienrbrt self-assigned this Jul 31, 2023
@julienrbrt julienrbrt mentioned this issue Oct 30, 2023
Closed
5 tasks
@julienrbrt julienrbrt mentioned this issue Nov 14, 2023
Merged
20 tasks
@github-project-automation github-project-automation bot moved this to 👀 To Do in Cosmos-SDK Nov 17, 2023
@julienrbrt julienrbrt mentioned this issue Nov 24, 2023
Closed
20 tasks
@julienrbrt julienrbrt mentioned this issue Oct 1, 2024
Closed
@JulianToledano JulianToledano mentioned this issue Oct 30, 2024
Open
6 tasks
@JulianToledano JulianToledano mentioned this issue Dec 5, 2024
Merged
12 tasks
@julienrbrt julienrbrt moved this from 📋 Backlog to 🤸‍♂️ In Progress in Cosmos-SDK Dec 5, 2024
@mergify mergify bot mentioned this issue Dec 11, 2024
Merged
12 tasks
@JulianToledano
Copy link
Contributor

completed in #22775

@github-project-automation github-project-automation bot moved this from 🤸‍♂️ In Progress to 🥳 Done in Cosmos-SDK Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JulianToledano JulianToledano

Labels
T: Client UX
Projects
Cosmos-SDK
Status: 🥳 Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(client/v2): prompt ui for any command cosmos/cosmos-sdk
2 participants
@JulianToledano @julienrbrt