Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification on SetFeePayer vs SetFeeGranter #18886

Closed
rootulp opened this issue Dec 25, 2023 · 2 comments · Fixed by #22526
Closed

Clarification on SetFeePayer vs SetFeeGranter #18886

rootulp opened this issue Dec 25, 2023 · 2 comments · Fixed by #22526
Assignees
Labels
S:zondax Squad: Zondax T: Dev UX UX for SDK developers (i.e. how to call our code) T:Docs Changes and features related to documentation.

Comments

@rootulp
Copy link
Contributor

rootulp commented Dec 25, 2023

Context

SetFeePayer(feePayer sdk.AccAddress)
SetGasLimit(limit uint64)
SetTimeoutHeight(height uint64)
SetFeeGranter(feeGranter sdk.AccAddress)

Problem

In a test file I'd like to construct a transaction that uses the feegrant module. I want account B to pay the fee for a transaction submitted by account A. I'm using TxBuilder but I'm not sure if I should invoke SetFeePayer or SetFeeGranter.

Proposal

It would help me if this interface contained a Godoc that explained which one should be invoked for my use case.

@github-actions github-actions bot added the needs-triage Issue that needs to be triaged label Dec 25, 2023
@github-project-automation github-project-automation bot moved this to 👀 To Do in Cosmos-SDK Dec 25, 2023
@rootulp
Copy link
Contributor Author

rootulp commented Dec 25, 2023

My test was failing because I was invoking SetFeePayer but appears to work how I would expect with SetFeeGranter. Since the naming here is confusing, I think docs would help.

Ref: celestiaorg/celestia-app@918c33d

@tac0turtle tac0turtle added T:Docs Changes and features related to documentation. and removed needs-triage Issue that needs to be triaged labels Dec 26, 2023
@tac0turtle
Copy link
Member

hey we are rewriting the client package. ill update this issue when we have the information

@raynaudoe raynaudoe mentioned this issue Apr 17, 2024
12 tasks
@julienrbrt julienrbrt added the T: Dev UX UX for SDK developers (i.e. how to call our code) label Oct 1, 2024
@educlerici-zondax educlerici-zondax moved this from 📋 Backlog to 🤸‍♂️ In Progress in Cosmos-SDK Oct 11, 2024
@educlerici-zondax educlerici-zondax added the S:zondax Squad: Zondax label Oct 11, 2024
@jonathanpberger jonathanpberger changed the title Clarification on SetFeePayer vs SetFeeGranter Clarification on SetFeePayer vs SetFeeGranter Nov 5, 2024
@github-project-automation github-project-automation bot moved this from 🤸‍♂️ In Progress to 🥳 Done in Cosmos-SDK Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S:zondax Squad: Zondax T: Dev UX UX for SDK developers (i.e. how to call our code) T:Docs Changes and features related to documentation.
Projects
Status: 🥳 Done
Development

Successfully merging a pull request may close this issue.

5 participants