Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide message router handler #19542

Closed
6 tasks done
Tracked by #19324
julienrbrt opened this issue Feb 23, 2024 · 3 comments
Closed
6 tasks done
Tracked by #19324

Provide message router handler #19542

julienrbrt opened this issue Feb 23, 2024 · 3 comments
Assignees
Labels
C:server/v2 Issues related to server/v2

Comments

@julienrbrt
Copy link
Member

julienrbrt commented Feb 23, 2024

Some modules require a message router handler (e.g gov or authz)
We need to make sure depinject can provide a stf compatible message router handler to such modules.
Additionally, we need a helper for those manually wiring those modules.

  • Introduce core router service
  • Implement router service in runtime
  • Implement router service in runtime/v2
  • Wire in x/gov
  • Wire in x/authz
  • Wire in x/group
@julienrbrt julienrbrt mentioned this issue Feb 23, 2024
11 tasks
@julienrbrt julienrbrt self-assigned this Feb 23, 2024
@github-actions github-actions bot added the needs-triage Issue that needs to be triaged label Feb 23, 2024
@julienrbrt julienrbrt added C:server/v2 Issues related to server/v2 and removed needs-triage Issue that needs to be triaged labels Feb 23, 2024
@github-project-automation github-project-automation bot moved this to 👀 To Do in Cosmos-SDK Feb 23, 2024
@julienrbrt julienrbrt changed the title Handle gov proposals Provide message router handler Feb 23, 2024
@tac0turtle
Copy link
Member

should we provide routers through env?

@julienrbrt
Copy link
Member Author

julienrbrt commented Feb 23, 2024

should we provide routers through env?

I don't think we should. If we ever want to move away from module being super user, we should not let any module be easily able to execute anything.

@tac0turtle
Copy link
Member

Whatever router is passed we should require the caller to be set

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:server/v2 Issues related to server/v2
Projects
None yet
Development

No branches or pull requests

2 participants