Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MsgSimulatorFn clean up #19782

Closed
JulianToledano opened this issue Mar 19, 2024 · 0 comments · Fixed by #19792
Closed

MsgSimulatorFn clean up #19782

JulianToledano opened this issue Mar 19, 2024 · 0 comments · Fixed by #19792
Assignees
@JulianToledano
Labels
C:Simulations

Comments

@JulianToledano
Copy link
Contributor

#19742 broke the simulation api as MsgSimulatorFn takes an address.codec as argument.
This is issue is meant to clean up MsgSimulatorFn as some arguments such as ctx are unused.
@JulianToledano JulianToledano self-assigned this Mar 19, 2024
@github-actions github-actions bot added the needs-triage Issue that needs to be triaged label Mar 19, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Cosmos-SDK Mar 19, 2024
@tac0turtle tac0turtle added C:Simulations and removed needs-triage Issue that needs to be triaged labels Mar 19, 2024
@JulianToledano JulianToledano mentioned this issue Mar 20, 2024
Merged
12 tasks
@JulianToledano JulianToledano linked a pull request Mar 20, 2024 that will close this issue
refactor!: MsgSimulatorFn clean up #19792
Merged
12 tasks
@github-project-automation github-project-automation bot moved this from 📋 Backlog to 🥳 Done in Cosmos-SDK Mar 20, 2024
@tac0turtle tac0turtle removed this from Cosmos-SDK Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JulianToledano JulianToledano

Labels
C:Simulations
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor!: MsgSimulatorFn clean up cosmos/cosmos-sdk
2 participants
@JulianToledano @tac0turtle