Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert simapp-v2-init to a tests/systemtests #20471

Closed
Tracked by #20439
kocubinski opened this issue May 28, 2024 · 1 comment
Closed
Tracked by #20439

convert simapp-v2-init to a tests/systemtests #20471

kocubinski opened this issue May 28, 2024 · 1 comment
Assignees
@tac0turtle
Labels
C:server/v2 Issues related to server/v2 T: Tests

Comments

@kocubinski
Copy link
Member

kocubinski commented May 28, 2024 •
edited
Loading

https://github.com/cosmos/cosmos-sdk/blob/cbab7352bbc50e0dc45079abdcc26ee7cecccc81/scripts/simapp-v2-init.sh should be a systemtest, not an ad-hoc shell script. it should run in CI.
@kocubinski kocubinski mentioned this issue May 28, 2024
Closed
21 tasks
@github-actions github-actions bot added the needs-triage Issue that needs to be triaged label May 28, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Cosmos-SDK May 28, 2024
@tac0turtle tac0turtle added T: Tests C:server/v2 Issues related to server/v2 and removed needs-triage Issue that needs to be triaged labels May 28, 2024
@coderabbitai coderabbitai bot mentioned this issue May 31, 2024
Merged
12 tasks
@tac0turtle tac0turtle self-assigned this Jul 18, 2024
@tac0turtle tac0turtle moved this from 📋 Backlog to 🤸‍♂️ In Progress in Cosmos-SDK Jul 18, 2024
@julienrbrt
Copy link
Member

julienrbrt commented Aug 13, 2024 •
edited
Loading

We've deleted that script, and simplified it to use our init simapp scripts and do the health check in a workflow. This is faster than a system test and quite useful (we have the same for v1). Don't think it's needed to change it.

@julienrbrt julienrbrt closed this as not planned Won't fix, can't repro, duplicate, stale Aug 13, 2024
@github-project-automation github-project-automation bot moved this from 🤸‍♂️ In Progress to 🥳 Done in Cosmos-SDK Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tac0turtle tac0turtle

Labels
C:server/v2 Issues related to server/v2 T: Tests
Projects
Cosmos-SDK
Status: 🥳 Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kocubinski @tac0turtle @julienrbrt