Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Add -Params support to runsim #20664

Closed
fmorency opened this issue Jun 13, 2024 · 3 comments
Closed

[Feature]: Add -Params support to runsim #20664

fmorency opened this issue Jun 13, 2024 · 3 comments

Comments

@fmorency
Copy link
Contributor

Summary

The simulator supports initializing its state using a params.json file containing module and simulation parameters, as described in https://docs.cosmos.network/main/learn/advanced/simulation#simulator-modes (option no.3).

As a user, I want the ability to provide a params.json file to runsim so it can be forwarded to go test.

Problem Definition

Such initialization using a parameter file is currently unsupported by runsim.

Proposed Feature

Add -Params support to runsim

@tac0turtle
Copy link
Member

we are actually removing the current runsim tool and making it work directly with the go tool system. This should help suffice with your feature correct?

@fmorency
Copy link
Contributor Author

we are actually removing the current runsim tool and making it work directly with the go tool system. This should help suffice with your feature correct?

If the new system allows for setting the operation weights of a given module and perform runs in parallel. then yes, it would suffice.

Is there anything I can do to help?

@tac0turtle
Copy link
Member

we just merged the pr replacing runsim with the go test toolkit system. #20490. This should work for you now, closing the issue. Reopen if anything else is needed

@github-project-automation github-project-automation bot moved this from 📋 Backlog to 🥳 Done in Cosmos-SDK Jun 18, 2024
@tac0turtle tac0turtle removed this from Cosmos-SDK Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants