Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove parseCmnError on new Tendermint version #2133

Closed
cwgoes opened this issue Aug 23, 2018 · 2 comments
Closed

Remove parseCmnError on new Tendermint version #2133

cwgoes opened this issue Aug 23, 2018 · 2 comments
Assignees
@fedekunze

Comments

@cwgoes
Copy link
Contributor

cwgoes commented Aug 23, 2018

Ref #2119 (review)

cc @fedekunze
@cwgoes cwgoes mentioned this issue Aug 23, 2018
Merged
5 tasks
@fedekunze fedekunze self-assigned this Aug 23, 2018
@alessio
Copy link
Contributor

alessio commented Sep 23, 2018

I think this could be closed, couldn't it?

@cwgoes
Copy link
Contributor Author

cwgoes commented Sep 24, 2018

I think this could be closed, couldn't it?

No, we should remove the parseCmnError function. This can be done in the TM 0.24 PR - #2219.

@cwgoes cwgoes mentioned this issue Sep 27, 2018
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fedekunze fedekunze

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@alessio @alexanderbez @cwgoes @fedekunze