Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ante Handler Min Fee Unit Tests #3100

Closed
4 tasks
alexanderbez opened this issue Dec 13, 2018 · 4 comments
Closed
4 tasks

Ante Handler Min Fee Unit Tests #3100

alexanderbez opened this issue Dec 13, 2018 · 4 comments

Comments

@alexanderbez
Copy link
Contributor

alexanderbez commented Dec 13, 2018

We don't have any unit tests testing minimum fee logic in the ante handler test suite.

/cc @zmanian


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@alexanderbez alexanderbez self-assigned this Dec 13, 2018
@alexanderbez alexanderbez removed their assignment Aug 30, 2019
@jackzampolin jackzampolin added this to the v0.38.0 milestone Sep 17, 2019
@alexanderbez alexanderbez removed this from the v0.38.0 milestone Nov 30, 2019
@alexanderbez
Copy link
Contributor Author

Can you please verify if this is still true @AdityaSripal ?

@AdityaSripal
Copy link
Member

There's a unit test at the decorator-level for it in x/auth/ante/fee_test.go: https://github.com/cosmos/cosmos-sdk/blob/master/x/auth/ante/fee_test.go#L14

We could add a test for it at the antehandler level tho. Don't have a test for it there yet

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@tac0turtle
Copy link
Member

we have tests now and min fee ante handler has been absorbed into other middleware

Repository owner moved this from Todo to Done in Cosmos SDK Maintenance Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants