Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider changing hard-coded Bcrypt cost parameter #3547

Closed
cwgoes opened this issue Feb 7, 2019 · 3 comments
Closed

Consider changing hard-coded Bcrypt cost parameter #3547

cwgoes opened this issue Feb 7, 2019 · 3 comments
Assignees
@cwgoes
Labels
T: Security
Milestone
v0.32.1 (Minor pr...

Comments

@cwgoes
Copy link
Contributor

cwgoes commented Feb 7, 2019

Presently the Bcrypt cost parameter is hard-coded to 12, with a long comment. Is this justified?
@cwgoes cwgoes added this to the v0.31.1 (Minor prelaunch fixes) milestone Feb 9, 2019
@cwgoes
Copy link
Contributor Author

cwgoes commented Feb 12, 2019

@ebuchman @liamsi Any thoughts?

@cwgoes cwgoes self-assigned this Feb 12, 2019
@cwgoes
Copy link
Contributor Author

cwgoes commented Feb 12, 2019

(this is for local encryption of keys)

@cwgoes
Copy link
Contributor Author

cwgoes commented Feb 12, 2019

@cwgoes to quickly check timings, ensure 80 bits of security.

@cwgoes cwgoes mentioned this issue Feb 13, 2019
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cwgoes cwgoes

Labels
T: Security
Projects
None yet
Milestone
v0.32.1 (Minor prelaunch fixes)
Development

No branches or pull requests
1 participant
@cwgoes