Common test harness code for IBC tests

[cwgoes]

De-duplicate this code & put it in a central location that can be imported.

ToDos:

• add x/ibc/testing/ pkg which sends through messages to create/update client, create connections/channels x/ibc: testing pkg #6356
• remove testchain from channel keeper Refactor 04-channel/keeper tests to ibc testing pkg #6400
• remove testchain from connection keeper
• remove testchain from ibc/ante
• remove testchain from clients

cc @fedekunze

[jackzampolin]

I think #5691 is a dupe of this issue. Going to repost that content here cc @AdityaSripal

[jackzampolin]

Tests on IBC require some cleanup along with end-to-end tests. Individual tasks include:

Cleanup:

• Cleaning up the TestChain methods and making them along with TestChain itself unexported
• Deleting all unused variables
• Commenting test functions so it is clear what they are intended to do
• Removing repeated code where possible (having a testing package within x/ibc with common test suite functionality could be useful).

Testing improvements:

• Create complete end to end tests that do nothing but start up 2 simapps and send messages to each other (which send & receive packets), while querying proofs as necessary
• Replace all mocked proofs with actual proofs retrieved from IAVL

Followup from #5711:

• Need to rewrite some of the failed test cases in 03-connection and 04-channel so that they fail for the stated reason in the test-case name
• Enforce consistency on connectionID naming through testsuites in 03-connection and 04-channel. Connection IDs are consistent within tests, but not across the entire test-suite which is important for understandability
• Write tests for TimeoutOnClose and CleanupPacket for ORDERED and UNORDERED channels
• De-duplify test setup code (mainly TestChain and queryProof) in 03-connection and 04-channel and move to separate test-utils package

[colin-axner]

from my look at testing so far, one good first step is to move TestChain/KeeperSuiteTest to a x/ibc/testing package. I can take this on if no one has started

[AdityaSripal]

I have not started, feel free to take this @colin-axner 👍

[colin-axner]

Following the merge of #6400, since the testing package will have stabilized in API, I think it'd be useful to do a pr for each file being updated rather than by pkg (as this has proved to result in a mega test refactor pr)

[colin-axner]

I'm starting on connection tests, will begin with handshake, then verify, then keeper

• handshake_test
• verify_test
• keeper_test

[colin-axner]

closing this issue since I believe the gist of it has been addressed. Any other test code that needs work or has issues should be opened with its own issue