types: add kv type #6897
Merged
types: add kv type #6897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tac0turtle
requested review from
aaronc,
alessio,
alexanderbez,
clevinson,
fedekunze and
jgimeno
as code owners
fedekunze
approved these changes
Jul 30, 2020
tac0turtle
added
the
A:automerge
Codecov Report
@@ Coverage Diff @@
## master #6897 +/- ##
==========================================
+ Coverage 60.75% 61.40% +0.64%
==========================================
Files 381 517 +136
Lines 24870 32050 +7180
==========================================
+ Hits 15110 19679 +4569
- Misses 8604 10802 +2198
- Partials 1156 1569 +413 |
colin-axner
suggested changes
Jul 30, 2020
colin-axner
approved these changes
Jul 30, 2020
tac0turtle
commented
Jul 30, 2020
tac0turtle
commented
Jul 30, 2020
| @@ -29,7 +29,7 @@ func TestRejectUnknownFieldsRepeated(t *testing.T) { | |||
| F: &testdata.TestVersion2{ | |||
| A: &testdata.TestVersion2{ | |||
| B: &testdata.TestVersion2{ | |||
| H: []*testdata.TestVersion2{ | |||
| H: []*testdata.TestVersion1{ | |||
There was a problem hiding this comment.
@odeke-em can you check this? when I ran make proto-gen it forced me to make these changes
aaronc
reviewed
Jul 30, 2020
| @@ -0,0 +1,10 @@ | |||
| syntax = "proto3"; | |||
| package cosmos.kv; | |||
There was a problem hiding this comment.
Not sure this needs a new package to itself, but I guess it's okay...
There was a problem hiding this comment.
i can change, let me know what you prefer
larry0x
pushed a commit
to larry0x/cosmos-sdk
that referenced
this pull request
May 22, 2023
* add kv type * add changelog entry * fix build * replace sdkkv with kv * revert change * fix some tests * proto-gen * fix tests Co-authored-by: Aleksandr Bezobchuk <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr creates a kv type directly in the sdk. Before this was in tendermint, but it was removed in 0.34.
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes