Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solo machine must use misbehaviour provided timestamp #7513

Closed
4 tasks done
colin-axner opened this issue Oct 12, 2020 · 0 comments · Fixed by #7515
Closed
4 tasks done

Solo machine must use misbehaviour provided timestamp #7513

colin-axner opened this issue Oct 12, 2020 · 0 comments · Fixed by #7515
Assignees
Labels

Comments

@colin-axner
Copy link
Contributor

colin-axner commented Oct 12, 2020

Summary of Bug

The solo machine uses the timestamp currently set in the consensus state to process misbehaviour. This is incorrect. Signatures signed at the same sequence but a different timestamp (anything greater than the consensus state timestamp) would fool the light client, but fail misbehaviour validation.

Solution

The timestamp needs to be a parameter provided in the misbehaviour for each signature.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant