Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove uses of LegacyAmino to unmarshal into arrays of proto messages #7559

Closed
blushi opened this issue Oct 15, 2020 · 1 comment
Closed

Remove uses of LegacyAmino to unmarshal into arrays of proto messages #7559

blushi opened this issue Oct 15, 2020 · 1 comment
Labels
C:Encoding

Comments

@blushi
Copy link
Contributor

blushi commented Oct 15, 2020

ref: #6194

LegacyAmino is still used with arrays of proto messages:

Two options to solve this:

  1. Implement some UnmarshalJSONArray function ;
  2. Wrap lists of proto.Message in some other message.
@blushi blushi mentioned this issue Oct 15, 2020
Closed
3 tasks
@tac0turtle
Copy link
Member

reopen if still relevant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C:Encoding
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@blushi @tac0turtle