Skip to content
This repository has been archived by the owner on Nov 30, 2021. It is now read-only.

LTS and Contributor Guidelines #719

Closed
okwme opened this issue Jan 15, 2021 · 4 comments
Closed

LTS and Contributor Guidelines #719

okwme opened this issue Jan 15, 2021 · 4 comments
Labels
stale stale PRs that will be closed if no further action occurs

Comments

@okwme
Copy link
Contributor

okwme commented Jan 15, 2021

Proposal: Add Contributor guidelines and protocol for v0.39.x LTS support

Current behavior: Currently work is going towards upgrading to v0.40.x in order to include IBC but there are teams like OKEX who are already contributing in supporting v0.39.x for at least 6 months. There are other teams in the ecosystem who are taking a conservative timeline to upgrading to stargate and provding a stable version of ethermint for them could be a good idea.

Desired behavior: Creating a protocol so that multiple teams have a clear path for contributing to the shared code base with maybe some agreements around where responsibilities lie. The Cosmos SDK could be a model for this protocol as outlined in the CONTRIBUTING.md and groups of developers to be part of assigning point release committees in a similar fashion.

Use case: So that the quality of Ethermint improves with multiple coordinated efforts instead of all contributions coming from a single organization

Requests may be closed if we're not actively planning to work on them.

@okwme
Copy link
Contributor Author

okwme commented Jan 15, 2021

cc @zhongqiuwoo @ColinSchwarz @fedekunze

@fedekunze
Copy link
Contributor

The issue with v0.39 LTS is that is is not production ready and still suffers from performance degradation. There are also a significant amount of bugs and improvements that would need to be made to account for a v0.39 stable. For example the fix for #667 would require a large refactor of the evm module (see #677 (comment)) which would necessarily introduce breaking changes.

There are also several issues that haven't been addressed yet like ledger compatibility, more e2e test for different opcodes and smart contracts, gas refund, gas estimation checks #497, docs, etc etc.

In summary, there are 2 main options for this:

  • Stability on v0.39 by addressing the issues outlined above
  • Stability on v0.40 (stargate) which will require significant updates to the existing PRs to migrate the repo to that version. Which I won't be available to help because my contract with ChainSafe ends

@hxrts
Copy link

hxrts commented Jan 15, 2021

cc @zhongqiuwood typo in your handle above^

@github-actions
Copy link

github-actions bot commented Mar 2, 2021

This issue is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the stale stale PRs that will be closed if no further action occurs label Mar 2, 2021
@github-actions github-actions bot closed this as completed Mar 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
stale stale PRs that will be closed if no further action occurs
Projects
None yet
Development

No branches or pull requests

3 participants