Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Proposals with Msgs with Approved signers #1478

Closed
AdityaSripal opened this issue Jun 1, 2022 · 4 comments
Closed

Replace Proposals with Msgs with Approved signers #1478

AdityaSripal opened this issue Jun 1, 2022 · 4 comments

Comments

@AdityaSripal
Copy link
Member

Now with the changes to governance and groups module in SDK v0.46, I think we can switch the governance proposals in IBC into regular msgs.

The messages will only succeed if they are signed by an approved list of senders that can be a parameter of IBC.

This allows us to support the current default behaviour by having the governance module account be one of the approved signers.

But we can also allow governance to delegate this responsibility to trusted groups and add the group account address to the approved sender list.

I believe this would be the preferred approach with SDK v0.46, correct me if im wrong @marbar3778

cc: @ValarDragon since I believe you were the one to bring up the inconvenience of governance-gated IBC recovery solutions

@ValarDragon
Copy link
Contributor

This would be awesome!

@colin-axner
Copy link
Contributor

colin-axner commented Aug 23, 2022

same issue as #1282. Do you have a preference to keep this open instead? Your justification for the change makes a lot of sense

@AdityaSripal
Copy link
Member Author

I think yours is more structured. Im ok with just copying any relevant rationale into your issue and closing this one thanks!

@colin-axner
Copy link
Contributor

cool I added some of the addition rationale for allowing of delegation to trusted groups

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants