Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update e2e tests to only run on PRs with changes to the codebase #2017

Closed
3 tasks
seantking opened this issue Aug 16, 2022 · 2 comments · Fixed by #2050 or #2186
Closed
3 tasks

Update e2e tests to only run on PRs with changes to the codebase #2017

seantking opened this issue Aug 16, 2022 · 2 comments · Fixed by #2050 or #2186
Assignees
@chatton
Labels
e2e needs discussion Issues that need discussion before they can be worked on
Milestone
v5.0.0

Comments

@seantking
Copy link
Contributor

Summary

At the moment we run the e2e tests on every PR. For example, this PR only contains a change to a README.md.

We should probably just run the e2e tests for changes to the core codebase.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@seantking seantking added needs discussion Issues that need discussion before they can be worked on e2e labels Aug 16, 2022
@chatton
Copy link
Contributor

chatton commented Aug 19, 2022 •
edited
Loading

this is a great idea and should definitely be done. We can get a long way by extending the paths-to-ignore option in all e2e workflows.

  paths-ignore:
    - docs/**
    - **.md

@chatton chatton self-assigned this Aug 19, 2022
@chatton chatton mentioned this issue Aug 19, 2022
Merged
9 tasks
@crodriguezvega crodriguezvega moved this to In progress in ibc-go Aug 19, 2022
@crodriguezvega crodriguezvega added this to the v5.0.0 milestone Aug 19, 2022
Repository owner moved this from In progress to Done in ibc-go Aug 23, 2022
@chatton chatton reopened this Sep 5, 2022
@chatton
Copy link
Contributor

chatton commented Sep 5, 2022

Reopening as the fix did not work as I expected, this is still happening. See this pr which only changes .MD files

@chatton chatton mentioned this issue Sep 5, 2022
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chatton chatton

Labels
e2e needs discussion Issues that need discussion before they can be worked on
Projects
ibc-go
Archived in project
Milestone
v5.0.0
3 participants
@crodriguezvega @chatton @seantking