Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use state enums in connection handshake log #3385

Closed
crodriguezvega opened this issue Mar 31, 2023 · 0 comments · Fixed by #3431
Closed

Use state enums in connection handshake log #3385

crodriguezvega opened this issue Mar 31, 2023 · 0 comments · Fixed by #3431
Labels
good first issue Good for newcomers type: code hygiene Clean up code but without changing functionality or interfaces

Comments

@crodriguezvega
Copy link
Contributor

Update hardcoded strings used within the ibc connection handshake code to use enum String() methods.

At the end of each handshake handler the previous state and current state is logged. Currently, the states are hardcoded.
Update them to use the correct enum String() methods.

See 03-channel/keeper/handshake.go. E.g. https://github.com/cosmos/ibc-go/blob/main/modules/core/03-connection/keeper/handshake.go#L149
@crodriguezvega crodriguezvega added good first issue Good for newcomers type: code hygiene Clean up code but without changing functionality or interfaces labels Mar 31, 2023
@crodriguezvega crodriguezvega mentioned this issue Mar 31, 2023
Closed
3 tasks
@expertdicer expertdicer mentioned this issue Mar 31, 2023
Merged
9 tasks
This was referenced Apr 10, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers type: code hygiene Clean up code but without changing functionality or interfaces
Projects
None yet
Milestone
No milestone
1 participant
@crodriguezvega