Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider making errors in internal/ public #3552

Closed
2 of 3 tasks
DimitrisJim opened this issue May 3, 2023 · 0 comments · Fixed by #3578
Closed
2 of 3 tasks

Consider making errors in internal/ public #3552

DimitrisJim opened this issue May 3, 2023 · 0 comments · Fixed by #3578
Assignees
@DimitrisJim
Labels
needs discussion Issues that need discussion before they can be worked on type: code hygiene Clean up code but without changing functionality or interfaces

Comments

@DimitrisJim
Copy link
Contributor

DimitrisJim commented May 3, 2023 •
edited
Loading

Summary

Make the errors currently residing in internal/ public.

Problem Definition

Currently, a number of errors mirroring errors in the sdk are defined in the internal folder. This makes them available for use internally in the ibc-go module but inaccessible from external modules.

Since these errors do get returned from certain functions in the ibc-go module it would make sense to have them also be available to external callers (one example of this is us in the e2e module whereby we require checking for the error returned, reference: #3475 (comment)).

Proposal

Make the errors currently defined as internal external.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@DimitrisJim DimitrisJim added needs discussion Issues that need discussion before they can be worked on type: code hygiene Clean up code but without changing functionality or interfaces labels May 3, 2023
@DimitrisJim DimitrisJim mentioned this issue May 3, 2023
Merged
9 tasks
@crodriguezvega crodriguezvega moved this to Todo in ibc-go May 15, 2023
@DimitrisJim DimitrisJim mentioned this issue May 15, 2023
Merged
9 tasks
@DimitrisJim DimitrisJim self-assigned this May 15, 2023
@DimitrisJim DimitrisJim moved this from Todo to In progress in ibc-go May 15, 2023
@DimitrisJim DimitrisJim moved this from In progress to In review in ibc-go May 15, 2023
@github-project-automation github-project-automation bot moved this from In review to Todo in ibc-go May 16, 2023
@DimitrisJim DimitrisJim moved this from Todo to Done in ibc-go May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DimitrisJim DimitrisJim

Labels
needs discussion Issues that need discussion before they can be worked on type: code hygiene Clean up code but without changing functionality or interfaces
Projects
ibc-go
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: make errors public cosmos/ibc-go
1 participant
@DimitrisJim