Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace FrozenSequence with IsFrozen boolean in Solomachine Client #36

Closed
AdityaSripal opened this issue Nov 5, 2020 · 2 comments · Fixed by #169
Closed

Replace FrozenSequence with IsFrozen boolean in Solomachine Client #36

AdityaSripal opened this issue Nov 5, 2020 · 2 comments · Fixed by #169
Assignees

Comments

@AdityaSripal
Copy link
Member

Unnecessary to have frozen sequence since we don't allow anything to verify before frozen sequence anyway.

@colin-axner
Copy link
Contributor

What is going to be returned for the FrozenHeight? 1?

@colin-axner
Copy link
Contributor

From 02-client Update

     // prevent update if the client is frozen before or at header height
    if clientState.IsFrozen() && clientState.GetFrozenHeight().LTE(header.GetHeight()) {
        return sdkerrors.Wrapf(types.ErrClientFrozen, "cannot update client with ID %s", clientID)
    }   

@colin-axner colin-axner transferred this issue from cosmos/cosmos-sdk Mar 4, 2021
@colin-axner colin-axner self-assigned this May 10, 2021
faddat referenced this issue in notional-labs/ibc-go Feb 23, 2022
faddat referenced this issue in notional-labs/ibc-go Mar 1, 2022
* add chain info

* add outline of fetch cmds

* download chain json file outline

* update json for test

* configure fetched chain automatically

* don't validate if client/conn ids are empty

* fetch paths for configured chains

* add default key & rpc-addr values

* adding path json files

* add hub path files

* testing

* revert changes

* better err handling and output

* finish path json files

* oops

* remove dead code & point to main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants